feat: New ScalingSet CRD to deploy isolated interceptors+scalers

kedacore / charts

Helm charts for KEDA

Apache License 2.0

157 stars 224 forks source link

feat: New ScalingSet CRD to deploy isolated interceptors+scalers #703

Open kahirokunn opened 3 weeks ago

kahirokunn commented 3 weeks ago

Provide a description of what has been changed

https://github.com/kedacore/http-add-on/pull/1014

Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] README is updated with new configuration values (if applicable) learn more
[x] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
- https://github.com/kedacore/http-add-on/pull/1014

Fixes #

Farfaday commented 1 week ago

Please add the crds.additionalAnnotations to the new CRDs. By copying this block for example: https://github.com/kedacore/charts/blob/main/keda/templates/crds/crd-scaledjobs.yaml#L7 Thanks!

kahirokunn commented 1 week ago

@Farfaday Thank you for your review! I have implemented all of the points you raised in your review.

imdmahajankanika commented 1 week ago

Hello! Is this feature about creating interceptor svc in the same namespace as application rather than KEDA namespace?

kahirokunn commented 6 days ago

Yes, that's correct! This feature allows for creating an interceptor service in the same namespace as the application. Additionally, it also supports creating a shared interceptor service if desired.

imdmahajankanika commented 5 days ago

Yes, that's correct! This feature allows for creating an interceptor service in the same namespace as the application. Additionally, it also supports creating a shared interceptor service if desired.

Thanks! So that means, instead of creating a service of type external name for interceptor service in the application namespace, I can directly connect ingress to the interceptor service in the application namespace.