search

keeferrourke / la-capitaine-icon-theme

La Capitaine is an icon pack designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design.
https://krourke.org/projects/art/la-capitaine-icon-theme
Other
1.95k stars 216 forks source link

[Bug] Most monochromatic icons don't follow KDE inherited colorscheme #118

Closed demoy closed 7 years ago

demoy commented 7 years ago

screenshot_20170302_062857

The 3 faulty icons in the sample above are, view-list-icons.svg, view-media-playlist.svg, and application-menu.svg in actions/22x22 (I think).

Most KDE users (myself incl.) use a light colorschemes making the issue inconspicous. After a quick glance over in status, and actions folders, 50-60% were found to ignore inheriting colorscheme. I am hoping an automated solution, such using your IDE of choice to find and replace offending lines from all project files, exists. If not, let me know and I will eventually submit a complete listing of affected files - its alot.

Mazino-Urek commented 7 years ago

I think listing the icons that I could not solve would be more efficient. My work is getting faster. Made quite some fixes in my fork. @keeferrourke Your feedback is vital now. Please define the color scheme you want. Do I work with the color fill I find in .svg?

demoy commented 7 years ago

Be aware that since the icons have changed. Some appearing on initial lists, are no-longer on the recent. I think that

@DarkknightAK another problem. Name: distribute-graph.svg

would be one of them. The fill colors here are a shade of blue and a light grey. I don't think you should change it.

I think listing the icons that I could not solve would be more efficient.

both list are in alphabetical order, so you could write off a block. assuming you were going sequentially.

EDIT: never mind. your distribute-graph.svg, looking at mine, is modified.

Mazino-Urek commented 7 years ago

@demoy After opening them in Inkscape I got the idea that they were multi-color. Don't worry, After editing the file I open with Inkscape before pushing the file. But I am really puzzled with this one, dialog-align-and-distribute.svg

<svg viewBox="0 0 22 22" xmlns="http://www.w3.org/2000/svg"><g fill="#f2f2f2" transform="matrix(0 .9975184 -1 0 21 -1028.795335653384)"><rect height="13.000001" ry=".5" width="6.000004" x="1034.3622" y="2"/><rect height="6" ry=".5" width="6.039805" x="1044.3622" y="9"/><rect height="1.5" ry=".5" width="15.999797" x="1034.3624" y="16.5"/></g></svg>

It is not color.

keeferrourke commented 7 years ago

@now-im most (if not all) icons should have been optimized by svgcleaner, so there may be some quirks. When in doubt, I would open in inkscape, select everything, ungroup, then convert all objects to paths, save the file, run svgcleaner, and check again.

As far as colourscheme is concerned, "-light" icons need to be #4d4d4d, "-dark" icons need to be #f2f2f2, "-symbolic" icons need to #bebebe (as per expectations for GNOME). There will be some exceptions to this rule, where icons contain gradients (ex. actions/22x22/adjusthsl.svg) or are intentionally coloured differently (ex. `colors-chroma.svg`).

In general, just use the colours defined in the SVG. I don't know how KDE styling expects to work with gradients, so perhaps ignore icons that use them.

demoy commented 7 years ago

@now-im, I keep seeing #f2f2f2 in the svg you post . So I am assuming, those files are from the "-dark" folders. I hope you didn't misunderstand. When I recommended modifying the light icons. I meant those in the "-light" folders. I AM REALLY SORRY, if I sent you otherwise.

Mazino-Urek commented 7 years ago

@keeferrourke Loud and clear. Then what about fill:#555555, fill:#565656. I think dialog-align-and-distribute.svg has escaped svg cleaning process.

@demoy Here is my methodology, In the folder, i search for the file using the name you provided. Two result shows up, one dark and one light. I open them simultaneouly in kate where a demo code is already loaded in another file. So, fixing them literary takes not much more time.

keeferrourke commented 7 years ago

@now-im replace #555555 and #565656 with #4d4d4d. I think that's some inconsistency with legacy stuff. The colours are pretty much exactly the same, but it's better if everything is #4d4d4d :grin:

Mazino-Urek commented 7 years ago

List of icons I could not fix:

Mazino-Urek commented 7 years ago

Good news everyone. With some hacking into the aur package of la-capitaine I was able to install my version in my system. I am seeing some changes. So, my work is paying off. Feels really nice. spectacle tj3449

keeferrourke commented 7 years ago

closing this because @now-im's merged PR #240 should fully address this.