Add Solidity, JS, and Go linting to CI

keep-network / keep-core

The smart contracts and reference client behind the Keep network

https://keep.network

MIT License

124 stars 75 forks source link

Add Solidity, JS, and Go linting to CI #1551

Open Shadowfiend opened 4 years ago

Shadowfiend commented 4 years ago

We're doing this in pre-commit hooks in most cases right now, but adding it to CI allows for contributors who may not install pre-commit hooks to not sneak through poor code.

[x] Solidity.
[ ] JS in Solidity directories.
[ ] JS in dApp directories.
[ ] JS in infrastructure directories.
[ ] Go.

See also #20.

dimpar commented 4 years ago

After briefly talking to @pdyraga , I'll take Solidity linting.

Shadowfiend commented 4 years ago

You can probably directly forklift what I did for keep-ecdsa in this commit. Still working on the Go side though.

dimpar commented 4 years ago

Thanks Antonio, PR for keep-core is ready.