keep-starknet-strange / zkramp

MIT License
27 stars 26 forks source link

[CONTRACTS] implement `_get_next_timestamp_key` tests #88

Open 0xChqrles opened 2 months ago

0xChqrles commented 2 months ago

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

ShantelPeters commented 2 months ago

@0xChqrles i will like to work on this

onlydustapp[bot] commented 2 months ago

Hey @ShantelPeters! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

mubarak23 commented 2 months ago

@0xChqrles am available to work on this.

I am an Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

onlydustapp[bot] commented 2 months ago

Hey @mubarak23! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Jemiiah commented 2 months ago

@0xChqrles I would love to work on this

onlydustapp[bot] commented 2 months ago

Hey @Jemiiah! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

bloomingpeach commented 2 months ago

I would like to work on this, I have experience contributing to open source projects and also working on Cairo codes.

https://github.com/keep-starknet-strange/raito/commits?author=bloomingpeach&since=2024-08-31&until=2024-09-23 https://github.com/keep-starknet-strange/shinigami/commits?author=bloomingpeach&since=2024-08-31&until=2024-09-23

onlydustapp[bot] commented 2 months ago

Hey @bloomingpeach! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Benjtalkshow commented 2 months ago

Hello @0xChqrles , Can I be assigned to this? I can tackle this issue asap.

onlydustapp[bot] commented 2 months ago

Hey @Benjtalkshow! Thanks for showing interest. We've created an application for you to contribute to Zkramp. Go check it out on OnlyDust!

Mystic-Nayy commented 2 months ago

@0xChqrles can I please be assigned to work on this?

leohscl commented 1 month ago

I'm up for this one @0xChqrles