zoidyzoidzoid commented 4 years ago

Pros:

This simplifies things vs a block list of ignored files/directories, since a block list means we'd have to add all editor files and other random things. This mainly only affects dev though, since most random files and directories won't exist in CI, so it's not really necessary.

Cons:

This is annoying cuz now people have to remember to add new root files/directories.

zoidyzoidzoid commented 4 years ago

I'm very okay with this not being accepted.

zoidyzoidzoid commented 4 years ago

Need to rebase this on the poetry changes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files          22       22           
  Lines         314      314           
=======================================
  Hits          229      229           
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3d411a...b74a4c1. Read the comment docs.

keep-the-receipts / procurement-portal-backend

.dockerignore allow list for smaller images #12

Codecov Report