keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.4k stars 1.48k forks source link

Clipboard not cleared when copying passwords from "Entry > Advanced > Additional attributes > [value of attribute]" #10524

Open notDavid opened 7 months ago

notDavid commented 7 months ago

Overview

Hi there, not sure if it's a bug, or a feature request... please advise thank you!

Steps to Reproduce

  1. Enable clipboard clearing after X seconds
  2. Create an entry, generate a password, and save it in an "Advanced Attribute" field
  3. Click "Protect" and "Reveal"
  4. Select the password from the "Advanced Attribute" value and copy the password to the clipboard with Cmd + v
  5. The clipboard is never cleared (i think it's also not marked as sensitive / a password, in the clipboard, either)

Expected Behavior

To clear the clipboard after X seconds

Actual Behavior

The clipboard is never cleared

KeePassXC - Version 2.7.7 Revision: 68e2dd8

Qt 5.15.11 Debugging mode is disabled.

Operating system: macOS 14.4 CPU architecture: arm64 Kernel: darwin 23.4.0

Enabled extensions:

Cryptographic libraries:

Operating System: macOS

notDavid commented 7 months ago

PS. Note that, the password is cleared correctly, after using the "Password Generator", which i mentioned in Step 2 above... but not when copying to the clipboard from an "Advanced Attribute".

droidmonkey commented 7 months ago

copying directly from a text edit field does not invoke the clipboard security since that process is handled directly by Qt. If you want to copy advanced attributes to clipboard with clearing use the right-click context menu from the main entry view.

image

notDavid commented 7 months ago

Thank you @droidmonkey , good to know there's an alternative.

I doubt whether the average users will be aware of this, it seems the most intuitive way to find and copy these passwords. So im curious, is it not implemented due to technical difficulties, or...?

Would it be a good idea to consider implementing, to prevent "leaks" ? (i only see advantages.)

Please consider, or feel free to close this issue otherwise. Thank you!

kaoneko commented 7 months ago

I'd say that right click menu is exactly where most users will look. Or the preview panel, where you can double click on an attribute's value to copy it (even when it's obscured). "Editing" an entry just to copy one of its secrets? That just seems weird to me 😄 And a very complicated way to achieve your goal ⛳️

notDavid commented 7 months ago

I'd say that right click menu is exactly where most users will look.

Yes, if you know what you're after. But not if you need to get an overview first of which items are in there.

Or the preview panel, where you can double click on an attribute's value to copy it

I didn't even know that! ☺️ (and i've been using KeePassXC for many years.) It's sort of, a hidden feature... 🤷🏼‍♂️

Good to know, though.