search

keifufu / WebNowPlaying-Rainmeter

Rainmeter Adapter for WebNowPlaying
MIT License
100 stars 4 forks source link

Possible update to how youtube handles thumbnails changing interactions with WebNowPlaying #21

Closed kswissgithub closed 1 month ago

kswissgithub commented 9 months ago

I don't know much about this stuff so please bear with me.

I noticed that the dynamic color feature on the monstercat rainmeter skin wasn't working correctly, but only on certain youtube thumbnails.

Normally when monstercat grabs cover art it can grab color data and adjust it's color to match the cover art. Monstercat is seemingly still grabbing the cover art/thumbnail with no issues, but the problem is the color data it's trying to pull from certain youtube thumbnails is not working as intended.

I was thinking it was an issue with monstercat itself but after doing some digging I'm starting to think there was a change to how youtube handles it's thumbnails and it's creating a new weird interaction with WebNowPlaying.

I don't know when this issue started exactly. I only noticed it yesterday, but I could've sworn everything was working as intended before this.

Here's some examples of what exactly I'm talking about, including the cover art files monstercat is grabbing.

exAyoutube exAmonstercatrm Example A: song info was grabbed from youtube. The color grabbed is incorrect (reading as white for some reason)

exByoutubemusic exBmonstercatrm Example B: song info was grabbed from youtube music. Same song url from example A but inputted into youtube music instead. The color grabbed is correct.

exCyoutubeconvert exC_exAmonstercat_converted Example C: I took the same thumbnail monstercat grabbed in Example A and re-exported it in adobe illustrator then replaced the original file with it. The color grabbed is correct?(grabbing dark red from edges instead or red from actual cover art. I'm assuming it's a monstercat thing and not WebNowPlaying).

One thing that might be of note is that the cover art grabbed from youtube in example A is unable to be opened in photoshop because it gives the error, "Not a PNG file"???

MPGxxYT commented 8 months ago

The file that comes out is actually a jpeg file. I was just about to write an issue about this. But it has .png as its extension. I don't know why. Used https://hexed.it to look at the binary data. image

keifufu commented 5 months ago

I don't plan to fix this, if rewritten using keifufu/WebNowPlaying-Library then this issue would be resolved as cover images are always properly converted to pngs there.

Feel free to create a PR if you can fix this issue, sorry.

keifufu commented 5 months ago

wip

keifufu commented 1 month ago

Fixed in v3, for which there is a prerelease on github now. Closing this as it is fixed, even though the pre-release is not yet stable and I do not recommend using it.