search

keikoproj / upgrade-manager

Reliable, extensible rolling-upgrades of Autoscaling groups in Kubernetes
Apache License 2.0
141 stars 45 forks source link

fix error 'failed to set instances to stand-by'. Refer https://github.com/keikoproj/upgrade-manager/issues/324 #329

Closed ameyajoshi99 closed 2 years ago

ameyajoshi99 commented 2 years ago

Fixes #324

codecov[bot] commented 2 years ago

Codecov Report

Merging #329 (f05a15a) into master (af9c12d) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   38.35%   38.35%           
=======================================
  Files           7        7           
  Lines         691      691           
=======================================
  Hits          265      265           
  Misses        401      401           
  Partials       25       25
Flag Coverage Δ
unittests 38.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/upgrade.go 44.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af9c12d...f05a15a. Read the comment docs.

shreyas-badiger commented 2 years ago

@ameyajoshi99 please set up DCO and sign your commits. Follow steps in this link - https://github.com/keikoproj/upgrade-manager/pull/329/checks?check_run_id=631029679 Screen Shot 2022-05-05 at 9 53 17 AM 1