search

kelseymh / G4CMP

A low energy condensed matter physics package for Geant4
GNU General Public License v3.0
28 stars 18 forks source link

G4CMP-12: Improve interface between MeshElectricField and TriLinearIn… #3

Closed tkreynolds closed 8 years ago

tkreynolds commented 8 years ago

The GetPotential and GetField functions have been moved out of G4CMPTriLinearInterp and into G4CMPMeshElectricField.

ragnese commented 8 years ago

Rebase develop and put new changes on top.

kelseymh commented 8 years ago

I've never been happy with passing around pointers in place of properly dimensioned arrays or vectors; there's no way to ensure proper size for either filling or referencing. Could you take a look at the alternate branch (G4CMP-12) where the Gradient() function returns a G4ThreeVector instead of a G4double*. Also, that alternate branch also has all of the Geant4-specific "[4]" position+time arguments reduced to "[3]" positions.

ragnese commented 8 years ago

Tyler is already on it.

On 09/06/2016 02:27 PM, Michael Kelsey wrote:

I've never been happy with passing around pointers in place of properly dimensioned arrays or vectors; there's no way to ensure proper size for either filling or referencing. Could you take a look at the alternate branch (G4CMP-12) where the Gradient() function returns a G4ThreeVector instead of a G4double*. Also, that alternate branch also has all of the Geant4-specific "[4]" position+time arguments reduced to "[3]" positions.