search

kelteseth / arewemodulesyet

https://arewemodulesyet.org/
MIT License
37 stars 11 forks source link

Allow to add new item in progress_overwrite.yml and add seastar #18

Closed ChuanqiXu9 closed 7 months ago

ChuanqiXu9 commented 7 months ago

See https://github.com/kelteseth/arewemodulesyet/issues/10 and https://github.com/kelteseth/arewemodulesyet/pull/16 for some background. It looks like we can't make it by simply editing the progress_overwrite.yml but have to edit the python scripts.

Tested locally.

kelteseth commented 7 months ago

Hi, sorry for the late reply. Do we need the changes in the python script? It copies the entry locally and the original code already copies everything into the merged progress.yml

grafik

Also do you think we should add a flag that this lib is not part of vcpkg? I'm myself not sure if this is needed...

ChuanqiXu9 commented 7 months ago

hi, this is not late. iirc, the script wouldn't handle the items not in raw_progress. yml. Then this is the reason why I touched the script.

Since I am not be able to touch the computer for few days. If you want, it might be more convenient for you to do or design everything you want.

I feel good as long as we can add libraries like seastar to the list. It doesn't matter if the pr gets merged or not :)

kelteseth commented 7 months ago

@ChuanqiXu9 you are correct, my bad. I have merged your script and the port changes here 3ef1f620c6de9d4ed3c767e6cf4e8dc36ddc744b so we can close the two PR. Thank you 💪