search

kenjdavidson / react-native-bluetooth-classic

⚛ Bluetooth classic Android(Bluetooth)/IOS(ExternalAccessory) module for serial communication
https://kenjdavidson.github.io/react-native-bluetooth-classic
MIT License
250 stars 94 forks source link

Update compile sdk version #294

Closed mrlmark closed 10 months ago

mrlmark commented 10 months ago

Run gradle assistant Apply recommended gradle changes Fix errors

mrlmark commented 10 months ago

@kenjdavidson This now builds w/ 0.73 android. Mostly auto-generated gradle stuff as a result of some version bumps. I don't know enough about Android module development to know if any of this is correct, so feel free to reject this if it's junk and i'll just build from my own fork.

kenjdavidson commented 10 months ago

@mrlmark do you happen to have a coles notes version of what changed in the main RNBluetoothClassicModule class? it looks like a bunch of prettier changes (awesome) but pretty annoying to try and look at what's changed for this version.

kenjdavidson commented 10 months ago

Was there no need to change the implementation? The issue that was opened for 0.73 of react had an error stating that the overriding/implementation was wrong in that either a method was removed or added. I didn't see anything that would have fixed this from what I can tell.

mrlmark commented 10 months ago

Was there no need to change the implementation? The issue that was opened for 0.73 of react had an error stating that the overriding/implementation was wrong in that either a method was removed or added. I didn't see anything that would have fixed this from what I can tell.

Sorry yeah, android studio auto-formatted it, should have disabled it beforehand.

Imported "import com.facebook.react.BuildConfig"

Removed a few @Overrides that were no longer overriding anything

Fixed one "@ReactMetho" typo to "@ReactMethod"

kenjdavidson commented 10 months ago

Either I'm drunk or reading the PR wrong, but it looks like the incoming changes have @ReactMetho. Am I crazy?

kenjdavidson commented 10 months ago

@mrlmark I think I see what's up, your branch is well behind main:

This branch is 3 commits ahead of,

42 commits behind kenjdavidson/react-native-bluetooth-classic:main.

Do you remember how you branched that? Looking at the main branch in your fork, it all looks good. But this one is behind a bunch, which is probably accounting for some of the issues. I can't accept it the way it is, but I really want to as it looks super close.

Ugh, nevermind, the task branch on my side is behind main. That makes no sense. I have no idea what happened, but something is messed up.

kenjdavidson commented 10 months ago

This PR and branch is all messed up.