kennydude / photosphere

Photosphere -- THIS IS A PROOF OF CONCEPT. NO SUPPORT IS GIVEN
http://kennydude.github.com/photosphere/test.html
218 stars 62 forks source link

Error when rendering the panorama #3

Open NielsPilon opened 11 years ago

NielsPilon commented 11 years ago

Hi,

I'm trying to add the panorama to a website based on the example that you've provided.

Added all the files and the script to the page but I get an error when creating the panorama after clicking on the link. This is the error that I see in the console WebGL: INVALID_VALUE: texImage2D: width or height out of range

The image for the panorama is 2580 x 1594px. Is that too big or is there something else that causes this error?

Any help would be appreciated.

kennydude commented 11 years ago

It must be a photosphere. if you can send me the original file via dropbox or something I can check On 21 Nov 2012 20:12, "NielsPilon" notifications@github.com wrote:

Hi,

I'm trying to add the panorama to a website based on the example that you've provided.

Added all the files and the script to the page but I get an error when creating the panorama after clicking on the link. This is the error that I see in the console WebGL: INVALID_VALUE: texImage2D: width or height out of range

The image for the panorama is 2580 x 1594px. Is that too big or is there something else that causes this error?

Any help would be appreciated.

— Reply to this email directly or view it on GitHubhttps://github.com/kennydude/photosphere/issues/3.

NielsPilon commented 11 years ago

Sure, how can I mail you? I'm completely new to GitHub....

Update: here's the link to the image https://www.dropbox.com/s/07hu3odz5lpq16x/PANO_20121121_101522.jpg

kennydude commented 11 years ago

Does this one work for you? http://kennydude.github.com/photosphere/test.html

If not what web browser/os are you using?

NielsPilon commented 11 years ago

Yes the demo works, I'm using OSX 10.8 and Chrome. The demo also works in Firefox but not in Safari.

kennydude commented 11 years ago

In Safari it should, which is really odd. It could be something to do with three.js but I'm not sure

NielsPilon commented 11 years ago

No, Safari shows a really broken image of the demo full of artifacts and it impossible to rotate the image. Or Safari just crashes..

kennydude commented 11 years ago

Hm, what version is that? i'll try to backlist it

On 21 November 2012 21:06, NielsPilon notifications@github.com wrote:

No, Safari shows a really broken image of the demo full of artifacts and it impossible to rotate the image. Or Safari just crashes..

— Reply to this email directly or view it on GitHubhttps://github.com/kennydude/photosphere/issues/3#issuecomment-10614318.

NielsPilon commented 11 years ago

Safari 6.

ghost commented 11 years ago

same error for me on chrome23 on osx, safari6 and firefox17 works, demo works everywhere.

edit: chrome23 on windows7 works too.

Steltek commented 11 years ago

I keep getting this in Firefox Nightly (21.0a1 (2013-01-26)), no matter if I resize the original picture or not:

[15:18:15.063]({full_width:"4166", full_height:"2083", crop_width:"4166", crop_height:"1169", x:"0", y:"144"})

[15:18:21.376] true [15:18:21.379] THREE.WebGLRenderer 52 [15:18:22.457] Error: WebGL: texImage2D: the maximum texture size for level 0 is 4096 @ http://tcnnet.com/pano/extern/three.min.js.pagespeed.jm.RPbJs7JNbl.js:8

Original file: http://tcnnet.com/pano/pano.jpg

The stest.jpg file works fine however.

P.S. The file works on another computer with NVIDIA GeForce 8800 GTX cards with Firefox 19.0. The failing PC has an Intel G45 onboard chipset.

P.P.S.: This sounds familiar: http://stackoverflow.com/questions/14414568/teximage2d-width-or-height-out-of-range-chrome-24

kennydude commented 11 years ago

Can you see if the issue is still persistent with the latest version?

petehalverson commented 11 years ago

I'm seeing the same issue on the latest version. Console output:

Object {full_width: "4286", full_height: "2143", crop_width: "4286", crop_height: "1664", x: "0"…} crop_height: "1664" crop_width: "4286" full_height: "2143" full_width: "4286" x: "0" y: "222"

true sphere.js:118 THREE.WebGLRenderer 58 three.min.js:408 WebGL: INVALID_VALUE: texImage2D: width or height out of range

(OS X 10.8.3 - Chrome 27.0.1453.110 - MBPr)

elafargue commented 11 years ago

Just sent a pull request that fixes this, FYI.

noamtcohen commented 10 years ago

@elafargue works for me, thanks!