kenygia / xy-vsfilter

Automatically exported from code.google.com/p/xy-vsfilter fork:xy-vsfilter-2015-05-04-rc
GNU General Public License v2.0
0 stars 0 forks source link

DVB Subtitles not Showing Correctly on Videos Larger or Smaller than 720x576 #108

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Using Zoom Player, play this test file: 
https://rapidshare.com/files/169776626/Subtitle_sync_example.ts
2. File has subtitles, as evidenced by playing it in MPC-HC.
3. No subtitles are showing in Zoom Player. Zoom Player dev has looked at the 
issue, and isn't sure if the problem is in the splitter, or xy-vsfilter. Thread 
here: http://forum.inmatrix.com/index.php?showtopic=13639

What is the expected output? What do you see instead?
Subtitles should be showing. Subtitles do not display however.

What version of the product are you using? On what operating system?
xy-vsfilter 3.0.0.63. Windows 7 64bit. Zoom Player 8.2.0 pre1.

Please provide related subtitle script (if any). And the less characters
the script is, the less effort I have to make to fix the issue, so if you
could make the script as simple as possible, that would be appreciated.

Please provide any additional information below.

Original issue reported on code.google.com by forum.an...@gmail.com on 30 Jul 2012 at 3:30

GoogleCodeExporter commented 9 years ago
Please report this to the MPC-HC project as well, since they are the maintainer 
of the DVB & PGS rendering code we're using. 

It appears they made some changes in the last few months which allow DVB 
subtitles to display with VSFilter 2.41 on that sample, but the rendering is 
messed up with YV12 (see attached image of VSFilter 2.41 r5672 + LAV Splitter). 
Only the MPC-HC ISR seems to display them correctly.

Once the MPC-HC project fixes this issue, we'll merge in the changes. I'll pass 
it along to our dev as well, but unless it's something trivial, all we can do 
is wait.

Original comment by cyber.sp...@gmail.com on 30 Jul 2012 at 5:26

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for looking into this. I've informed the Zoom Player dev's of the info 
you have provided as well. Using XhmikosR's 26 July build of DirectVobSub (a 
2.41 variant) with Zoom Player, I see basically exactly the same thing as in 
the MPC-HC screenshot in your post, which I found interesting.

Original comment by forum.an...@gmail.com on 31 Jul 2012 at 10:35

GoogleCodeExporter commented 9 years ago
Ticket logged into the MPC-HC bug tracker as requested:
http://sourceforge.net/apps/trac/mpc-hc/ticket/2516

Original comment by forum.an...@gmail.com on 31 Jul 2012 at 11:18

GoogleCodeExporter commented 9 years ago
The following MPC-HC DVB commits are related to things other than this issue, 
but I'm linking them below so they're easier to find when we get around to 
merging the newer code into xy-VSFilter.

https://github.com/mpc-hc/mpc-hc/commit/eb81441ba36b1a55c247968f7451952c646059a2
https://github.com/mpc-hc/mpc-hc/commit/09ec4dd83d543a8582d7e99d05fb5241ec3546f7
https://github.com/mpc-hc/mpc-hc/commit/aa116ba606d25738684c47d9e5c8f90aabe049ac
https://github.com/mpc-hc/mpc-hc/commit/6170fff2e901f44f06bf02eb17aaad3195969d58
https://github.com/mpc-hc/mpc-hc/commit/14580e632cdf2720a34bdb2c7037db0396627f50
https://github.com/mpc-hc/mpc-hc/commit/09463d6ff3ad5214d9093df9ce33d0022b6958b6
https://github.com/mpc-hc/mpc-hc/commit/950dbb6208785efd72b3e6a3b8abba88ba5d9a16
https://github.com/mpc-hc/mpc-hc/commit/d8efb5eebeb4b65704db60520fd2168982da736e

Original comment by cyber.sp...@gmail.com on 24 Sep 2012 at 4:07

GoogleCodeExporter commented 9 years ago
There was some additional testing done by the person who reported the issue. 
Rather than copying and pasting here, I will just link to the posts:
1. http://forum.inmatrix.com/index.php?showtopic=13639&#entry51587
2. http://forum.inmatrix.com/index.php?showtopic=13639&st=20#entry51589
3. http://forum.inmatrix.com/index.php?showtopic=13639&st=20#entry51590
4. http://forum.inmatrix.com/index.php?showtopic=13639&st=20#entry51592

Original comment by forum.an...@gmail.com on 1 Oct 2012 at 9:52

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by cyber.sp...@gmail.com on 22 Nov 2012 at 10:26

GoogleCodeExporter commented 9 years ago
I believe this issue has been resolved when using XySubFilter 3.1.0.546 Beta 
with madVR. Please test it out.

Unfortunately xy-VSFilter (VSFilter.dll) still behaves the same as always.

Original comment by cyber.sp...@gmail.com on 22 Jul 2013 at 2:40

GoogleCodeExporter commented 9 years ago
Hm, I just tested with that version of XySubFilter and the latest beta of Zoom 
(8.70 Beta 12). I disabled Smart Play in Zoom so that XySubFilter would work, 
but though XySubFilter is shown in the Filter Properties menu, none of the test 
clips show subtitles. It's possible that despite Smart Play being disabled, 
something is still interfering - XySubFilter just shows 'none' after the name 
in Filter Properties, whereas with MPC, it shows 'connected with madVR' after 
the name in Filters.

Original comment by forum.an...@gmail.com on 23 Jul 2013 at 10:18

GoogleCodeExporter commented 9 years ago
Not showing 'connected with madVR' even when connected seems to be a ZoomPlayer 
issue since it is shown correctly in ZoomPlayer's Graph Information dialog. As 
soon as I enable the DVB subtitle track in LAV Splitter, they show just fine 
with madVR 0.86.10

I'm unable to reproduce this in Zoom Player 8.70 Beta 12. Are you positive 
something else is not connecting to the subtitle pin? Are you positive you are 
testing with XySubFilter 3.1.0.546 Beta and not one of the other builds I 
provided to Blight which had auto-loading disabled?

In ZoomPlayer, it seems as if something called a "Internal Script Command 
Renderer" will connect to LAV Splitter's only subtitle pin with TS+DVB 
subtitles when Smart Play is disabled, but only if you have XySubFilter set to 
not load not itself with embedded subtitles. LAV Splitter seems to blame for 
exposing a "NULL" subtitle pin with DVB sub, but ZoomPlayer should likely block 
this "Internal Script Command Renderer" filter since it obviously cannot render 
DVB subtitles.

Original comment by cyber.sp...@gmail.com on 23 Jul 2013 at 10:57

GoogleCodeExporter commented 9 years ago
Ah, your system uses LAV? As soon as I disable Smart Play, Zoom uses Haali's 
here (and because Smart Play is disabled, I can't control what splitter Zoom 
uses - Haali's obviously has a higher merit than LAV).

I am sure about the version of XySubFilter though - got it direct from the 
Download page a few minutes before that post.

Original comment by forum.an...@gmail.com on 23 Jul 2013 at 11:35

GoogleCodeExporter commented 9 years ago
Ok, I couldn't make Zoom block Haali's, so I uninstalled it (I normally have 
everything in Install Center installed). Zoom now uses LAV with Smart Play 
disabled, and that does indeed seem to make a difference to whether the subs 
work with all those test clips.

Original comment by forum.an...@gmail.com on 23 Jul 2013 at 11:43

GoogleCodeExporter commented 9 years ago
Yeah, Haali Splitter doesn't support subtitles with TS/M2TS files at all. 
Another option if you mistakenly install Haali Splitter with TS support 
enabled, is you can run "regsvr32 /u" on the Haali Splitter ts.dll only to 
disable it again.

> LAV with Smart Play disabled, and that does indeed seem to make a difference
> to whether the subs work with all those test clips.

I'm relieved that was the only issue. 

So does it seem to work as expected on such DVB subtitles now?

Original comment by cyber.sp...@gmail.com on 23 Jul 2013 at 2:01

GoogleCodeExporter commented 9 years ago
Yes, on all those 5 samples, subtitles now show. The only thing - and this may 
simply be the way those subs were encoded - is that on the original 
Subtitle_sync_example.ts clip, the text of the subtitles show on an ugly black 
rectangle (you can sort of see the black rectangle in the screenshot in the 
first post). I don't have a lot of experience with subtitles, but I am more 
used to them just showing the text and nothing else (the background is 
transparent, not solid black).

Original comment by forum.an...@gmail.com on 24 Jul 2013 at 10:22

GoogleCodeExporter commented 9 years ago
DVB subtitles are European closed captions aren't they? At least here in the 
USA, closed captions (usually transcripts for deaf and hard of hearing, not 
subtitles mind you) on TV almost always show these black background boxes by 
default, so I think that's just how it is. 

Currently I believe the MPC-HC DVB subtitle code always uses the colors, style, 
background as encoded within DVB subtitles themselves by the TV station and 
defined by the actual specification. If you desire a change to customize the 
style of closed captions (assuming that's possible), you'll need to make a 
feature request with MPC-HC at the following, as they are the maintainer of the 
PGS/DVB/HDMV code:

https://trac.mpc-hc.org/wiki/How_to_Report_Issues

Original comment by cyber.sp...@gmail.com on 24 Jul 2013 at 11:24