keraJLi / rejax

Apache License 2.0
150 stars 7 forks source link

Change observation normalization logic in ddpg, td3, dqn #2

Open keraJLi opened 9 months ago

keraJLi commented 9 months ago

In these algorithms, the observations are normalized before being passed to update (see https://github.com/keraJLi/pureRL/blob/5ed017666be48ab0d3976d84a3557839d527dc08/purerl/algos/ddpg/ddpg.py#L123). Passing unnormalized observations would give more freedom when creating sublcasses. Should change it to be that way!

keraJLi commented 9 months ago

This also applies to sac as of 86a2c65.