keras-team / keras-tuner

A Hyperparameter Tuning Library for Keras
https://keras.io/keras_tuner/
Apache License 2.0
2.86k stars 396 forks source link

Update oracle_client.py to enable_http_proxy #981

Open pbk0 opened 12 months ago

pbk0 commented 12 months ago

Line 35 anyway makes an insecure channel and expects that users are on a safe network. But it still uses https urls and some corporate environments try to verify certificates (as in my case) and it breaks. So adding the second line instead of the first worked in my case and ends up using http links.

# original
channel = grpc.insecure_channel(f"{ip_addr}:{port}")
# update to this
channel = grpc.insecure_channel(f"{ip_addr}:{port}", options=(('grpc.enable_http_proxy', 0),))
google-cla[bot] commented 12 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (92d713a) 98.37% compared to head (895503f) 98.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #981 +/- ## ======================================= Coverage 98.37% 98.37% ======================================= Files 50 50 Lines 3085 3085 ======================================= Hits 3035 3035 Misses 50 50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.