roll.sh: fix playing audio on GNU/Linux (aplay)

keroserene / rickrollrc

Rick Astley invades your terminal.

1.38k stars 157 forks source link

roll.sh: fix playing audio on GNU/Linux (aplay) #23

Open rrthomas opened 6 years ago

rrthomas commented 6 years ago

The argument -Dplug:default was stopping sound working; removing it makes it work again.

Rather to my surprise, it also worked with the rest of the arguments removed. This seems odd given that it claims to be downloading a raw audio file, but removing -q showed that the audio data aplay was being fed is in fact a WAV file, and downloading the file and checking it confirms this.

Hence, refer to “wav audio” rather than “raw audio”, and remove all command-line arguments to aplay. Win!

diversemix commented 5 years ago

:+1: ... :pray: please can we get this one in?

keroserene commented 5 years ago

👍

rrthomas commented 2 years ago

As far as I can tell, this is still needed, and I've rebased on current master.

rrthomas commented 2 years ago

I have updated this PR to fix things today; the fix is a bit different from four years ago!