search

keroserene / rickrollrc

Rick Astley invades your terminal.
1.38k stars 157 forks source link

Adding cygwin audio support #3

Closed mrpants closed 11 years ago

mrpants commented 11 years ago

Install the "sox" package in cygwin to get the play executable installed. That can play the raw sound file without a problem!

jart commented 11 years ago

Can you modify your commit to mention in the README that cygwin users need to install sox?

jart commented 11 years ago

Also you should have it play the .gsm.wav file instead of the raw s16 file because it uses less bandwidth and will allow you to get rid of a lot of the flags to the play command since the wav headers provide that data.

jart commented 11 years ago

Thanks so much for taking the time to contribute your first pull request btw!

mrpants commented 11 years ago

OK, the README updated, and we're now using the WAV file instead. We still need the -q flag to keep play quiet, but it worked without any issue.

I created a new commit as I was getting lost in rebase-land. Haven't had to work that before. Sorry if it's any extra hassle!

And you're welcome, but thank you for creating such an awesome and silly script!

keroserene commented 11 years ago

Verified that it doth work as expected. :+1: Thanks again for your enhancement to this lulzy script!