search

keroserene / rickrollrc

Rick Astley invades your terminal.
1.38k stars 157 forks source link

Github raw url and curl fixes #7

Closed mvdan closed 9 years ago

dasilvacontin commented 9 years ago

@mvdan, squash commits.

mvdan commented 9 years ago

Each commit does a different thing.

mvdan commented 9 years ago

Ping @keroserene

keroserene commented 9 years ago

We already have plenty of commits that are at the level of "bunch of README updates" or larger - squashing these 3 sounds reasonable to me and would prevent commit history bloat, if you don't mind :) Thank you!

mvdan commented 9 years ago

I don't think this is commit history bloat as long as each commit does a different thing :) This way, if something breaks, you can pinpoint it to a single commit and revert it since it only did that thing, instead of partially reverting a "bug fixes" commit that does three things at a time.

If you still want me to squash before merging, I can squash them.

keroserene commented 9 years ago

Totally agreed in general, although these are 3 miniscule changes to a README and I don't find there's risk of future break pinpointing shenanigans in this case. Please squash ;)

mvdan commented 9 years ago

Done.

keroserene commented 9 years ago

Thanks for spending time on this thing :+1:

mvdan commented 9 years ago

Ha, now that I have contributed to rickrollrc my life is finally complete!

dasilvacontin commented 9 years ago

Now you can run forever mvdon!

mllobet commented 9 years ago

corre mvdon