search

kervyntan / pe

0 stars 0 forks source link

Developer Guide - PersonXYZPredicate #13

Open kervyntan opened 5 months ago

kervyntan commented 5 months ago

Screenshot 2024-04-19 at 5.19.25 PM.png

Description

PersonXYZPredicate illustrated in the diagram can be confusing to the reader, might be better to just have a sequence diagram illustrates finding using PersonNamePredicate, in which case, as the developer looks through the files they'll observe the other PersonPredicates.

nus-se-script commented 5 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for the bug report.

Our team has decided to reject this bug as we wanted to generalise this sequence diagram to be representative of all Predicate classes. Following Prof's advice in this issue here, we also included the explanation what PersonXYZPredicate in the following section:

Screenshot 2024-04-21 at 18.33.50.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]