kervyntan / pe

0 stars 0 forks source link

No warning/prompt to user for clearing all entries from contact list #7

Open kervyntan opened 5 months ago

kervyntan commented 5 months ago

Description

No warning/prompt to user for clearing all entries from contact list. Understood that it has been stated in the User Guide, and from my perspective, it feels like a confirmation to do so should be provided in the case where a user happens to keyed it in by accident, or a scenario comes up where they didn't mean to clear all their contacts.

Steps to reproduce

  1. Launch the application for the first time to load initial data.

  2. Run clear.

Expected behaviour

A warning/prompt for confirmation from the user on deletion of ALL the contacts should be provided as deletion can result in permanent data loss.

Actual behaviour

Address book is cleared without prompt.

soc-se-bot commented 5 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Clear command does not prompt for confirmation

image.png

The clear command does not prompt for confirmation from the user. This can cause very disastrous effects, as a financial advisor might inadvertently type in the command, causing them to lose all data related to clients, which might be very valuable to the financial advisor and can cause serious consequences for them.

The expected functionality is that there should be a prompt confirming that the user wishes to run the clear command.


[original: nus-cs2103-AY2324S2/pe-interim#765] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the bug report.

We are aware of the issue and have put it in our Planned Enhancements:

Screenshot 2024-04-21 at 17.01.43.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]