search

kesha-antonov / react-native-background-downloader

About A library for React-Native to help you download large files on iOS and Android both in the foreground and most importantly in the background.
https://www.npmjs.com/package/@kesha-antonov/react-native-background-downloader
Other
72 stars 14 forks source link

[Android] onProgress doesn't throw any error if it encounters the error ERROR_INSUFFICIENT_SPACE #34

Open ng-ha opened 3 days ago

ng-ha commented 3 days ago

Is this a bug report, a feature request, or a question?

Bug report

Have you followed the required steps before opening a bug report?

(Check the step you've followed - put an x character between the square brackets ([]).)

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?

Android

Is the bug related to the native implementation? (NSURLSession on iOS and Fetch on Android)

Yes

Environment

Environment: React: 18.2.0 React native: 0.74.3 react-native-background-downloader: 3.2.2

Expected Behavior

onProgress should throw any error if it encounters the error ERROR_INSUFFICIENT_SPACE (errorCode: 1006), like IOS does (errrorCode: -1)

Actual Behavior

onProgress doesn't throw any error if it encounters the error ERROR_INSUFFICIENT_SPACE (errorCode: 1006), like IOS does (errrorCode: -1). It gets stuck in progress.

ng-ha commented 3 days ago

the PR(https://github.com/kesha-antonov/react-native-background-downloader/pull/32) does fix the issue. Please consider to merge it!