Confirm that BMV-712 provides the same data as the smartshunt

keshavdv / victron-ble

A Python API to parse Victron Instant Readout BLE advertisements

The Unlicense

102 stars 34 forks source link

Confirm that BMV-712 provides the same data as the smartshunt #3

Closed stefanor closed 1 year ago

stefanor commented 1 year ago

Hah, I've just spent half a day trying to reverse-engineer the protocol, myself. I'm glad to see I was on the right track, but you got many more details figured out :)

For a BMV-712, the data looks correct.

stefanor commented 1 year ago

I don't think the model mapping update is necessary (it's really a model "override" if a particular product only implements a subset of the values) since the library already uses a byte from the packet to figure out what type it is.

Ack. I wasn't sure what the intention was there.