kestra-io / kestra

:zap: Workflow Automation Platform. Orchestrate & Schedule code in any language, run anywhere, 500+ plugins. Alternative to Zapier, Rundeck, Camunda, Airflow...
https://kestra.io
Apache License 2.0
13.69k stars 1.18k forks source link

Improvements of new filter functionality #5845

Open MilosPaunovic opened 3 weeks ago

MilosPaunovic commented 3 weeks ago

Right now, there are new filters only on Executions page. It's not yet fully completed, but it's being merged so I can get more feedback from the rest of the team.

Below is the list of known issues and tasks to be implemented, anything else you find or notice, feel free to add as comment below and it will be amended.

Related issue https://github.com/kestra-io/kestra/issues/4664.

elevatebart commented 2 weeks ago

notes from Demo

The options popper at the end of the filter bar looks like a tooltip. Could we make the content a little lighter in dark mode? (might be element plus) Placeholder color looks exactly like paragraph text. Is it normal? It does not feel normal. Could we have the comparator ("is") be in a different color to improve readability (specially since text is incredibly small) Date filters ideas

MilosPaunovic commented 2 weeks ago

Updated the issue description with Bart's notes from the comment above, and, with notes from the rest of the team collected during the demo.

brian-mulier-p commented 2 days ago

More of a QOL thing but would be great if clicking on an existing filter would allow changing the values for it (I know it has some challenges like what to change because we don't have multiple boxes to separate comparator, key and value), maybe allow changing the value upon clicking for now ?

anna-geller commented 1 day ago

@MilosPaunovic can we split this in to what's critical and must be done before release on Tuesday and the rest we can do later? 🙏

MilosPaunovic commented 1 day ago

Nothing remaining seems critical.