search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Use case-sensitive newtonsoft.json reference #104

Closed ivantm closed 5 years ago

ivantm commented 5 years ago

Hello @kevbite 👋

The loose casing of newtonsoft.json in CompaniesHouse.csproj is causing some errors for me when using this package.

screen shot 2019-01-23 at 12 41 50 pm

It seems there are some inconsistencies in when package references are and aren't case-insensitive, and I seem to be hitting that.

I have tested this by changing the casing, building the package locally, referencing that package in my project and confirming the build error disappears, then reverting the casing change, rebuilding the package locally and confirming the error re-appears.

kevbite commented 5 years ago

Hello, @ivantm I've never bumped into this issue before, what tools etc... are you using? Did a bit of googling and found this I'm just overly curious.

Happy to merge in this PR

ivantm commented 5 years ago

what tools etc... are you using

I'm using Visual Studio 2015 (update 3) on Windows 10 on a project that not yet been upgraded to VS2017 (which is what I used to build CompaniesHouse.NET when testing). The project I'm contributing to has both CompaniesHouse.NET and Newtonsoft.Json as a dependency:

screen shot 2019-01-24 at 9 34 07 am

Fortunately, 6.1.9 works a treat - I'm not sufficiently proficient with .net to dig a lot deeper (it could be that the issue you linked post-dates whatever stack of tools is bundled with VS2015) ... but thank you for merging!

screen shot 2019-01-24 at 9 32 27 am
kevbite commented 5 years ago

Ah @ivantm I see, what an odd issue. Thanks for posting the extra information