search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

New Enumrerations for Response #129

Closed johnmackerras closed 3 years ago

johnmackerras commented 4 years ago

CompaniesHouse.Response needs some more/new enumerations:

CompaniesHouse.Response.FilingCategory

CompaniesHouse.Response.FilingSubcategory

CompaniesHouse.Response.PersonsWithSignificantControl.PersonWithSignificantControlKind

Note: Super Secure is just a person object wth identifiers removed

Note: Legal Person is a new Kind which had two unique fields 'LegalAuthority' and 'LegalForm'.

johnmackerras commented 4 years ago

Sorry, voluntary-arrangement is in FilingSubcategory, not FilingCategory

kevbite commented 4 years ago

Hey @johnmackerras I can't seem to see them extra fields of LegalAuthority and LegalForm in the docs? https://developer.companieshouse.gov.uk/api/docs/company/company_number/persons-with-significant-control/list-resource.html

kevbite commented 4 years ago

The new enumerations are now part of version 7.8.0

johnmackerras commented 4 years ago

Hi Kevin,

https://developer.companieshouse.gov.uk/api/docs/company/company_number/persons-with-significant-control/legalPerson-resource.html

Look for identification.legal_form identification.legal_authority

kevbite commented 4 years ago

This library only currently does the listing of the company persons with significant control. https://github.com/kevbite/CompaniesHouse.NET/blob/master/src/CompaniesHouse/CompaniesHousePersonsWithSignificantControlClient.cs#L20

There seem to be loads more endpoints now to get more details and it seems them properties are on the resources:

https://developer.companieshouse.gov.uk/api/docs/company/company_number/persons-with-significant-control/listPersonsWithSignificantControl.html

sakisk commented 3 years ago

Closing this as work scheduled in #144 will add all enumerations for each endpoint