search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Companies type missing error, new types need to be added #149

Closed mattu08 closed 3 years ago

mattu08 commented 3 years ago

Hi,

I started to get a few errors for the following company types:

UKEIG example: GE000100 UK SOCIETAS example: SE000010

Then realized that the two types were missing, could you add the missing company types:

ukeig united-kingdom-societas

To /src/CompaniesHouse/Response/CompanyType.cs https://github.com/kevbite/CompaniesHouse.NET/blob/efef661d99dc64b38ed560e6d908695649f3ac1e/src/CompaniesHouse/Response/CompanyType.cs

Cheers,

Matt

kevbite commented 3 years ago

Hey @mattu08, thanks for raising this issue, I've updated the code to reflect the API responses. You're faster at finding the API changes than their own api-enumeration documentation being updated 😉.

kevbite commented 3 years ago

This is now in the NuGet release 7.9.4. If you spot any other changes please feel free to open another issue. Thanks.

mattu08 commented 3 years ago

Haha, No problem @kevbite will do! Thanks for adding the fix in 👍.