search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

New Company CompanyStatusDetail Status need to be added. #150

Closed mattu08 closed 3 years ago

mattu08 commented 3 years ago

Hi,

Just found two errors for missing Status:

converted-to-ukeig Example: GE000091 converted-to-uk-societas Example SE000010

These are missing from the following location: CompaniesHouse.Response.CompanyStatusDetail https://github.com/kevbite/CompaniesHouse.NET/blob/master/src/CompaniesHouse/Response/CompanyStatusDetail.cs

Thanks again,

Matt

mattu08 commented 3 years ago

Hopefully there are no more issues with these two linked to other types etc. Also having converted-to- is slightly worrying, just in case Companies House has started to use this structure for other company types etc. There would then be quite a few too add in.

kevbite commented 3 years ago

Just pushed up the 2 changes for them, I agree that would be slightly annoying but if they followed some convention we could convert it into something a little easier.

kevbite commented 3 years ago

This is in the latest NuGet package now 7.9.5

mattu08 commented 3 years ago

I agree it's pretty much like a break and fix type of scenario at the moment with them, anyway thanks again for getting this added in. Cheers 👍

mattu08 commented 3 years ago

I'll close the ticket.