search

kevbite / CompaniesHouse.NET

A simple .NET client wrapper for CompaniesHouse API
MIT License
37 stars 44 forks source link

Missing value 'notifications' in CompaniesHouse.Response.FilingSubcategory enum #79

Closed vinhalo closed 6 years ago

vinhalo commented 6 years ago

The following exception occurs when getting the Filing History for certain companies :

Error converting value \"notifications\" to type 'CompaniesHouse.Response.FilingSubcategory'.

kevbite commented 6 years ago

Hello, Do you have an id as an example so we can test this?

vinhalo commented 6 years ago

Hi there,

If you try getting the filing history (50 items per page) for company 10225670 you should encounter the error.

Thanks

kevbite commented 6 years ago

Thanks, I'll try to sort this out soonish... unless you fancy having a go and submitting a PR.

vinhalo commented 6 years ago

Yeah I can have a stab shouldn't be too difficult cheers.

vinhalo commented 6 years ago

PR submitted.

kevbite commented 6 years ago

Thanks, It's just building and will be released soon in version 4.0.5