kevin-montrose / Sigil

A fail-fast validating helper for .NET CIL generation
Microsoft Public License
988 stars 92 forks source link

.NET Core 1.0 -> 3.0 Upgrade #62

Closed NickCraver closed 5 years ago

NickCraver commented 5 years ago

This change set:

This works in the latest VS 16.3 release (currently preview) or standalone with the .NET Core 3.0-preview9 SDK.

To build (from solution root)

# To Build
dotnet build
# To Run Tests (net461, netcoreapp2.2, netcoreapp3.0)
dotnet test
# To Generate NuGet
dotnet pack .\src\Sigil\Sigil.csproj -c Release /p:PackageOutputPath=..\..\.nupkgs /p:CI=true

I'm happy to add build scripts, but with 1 project/lib it's not that complicated yet either...so leaving them off.

Note: there are a few test failures under netcoreapp that need some investigation. These are all setup to easily debug in Visual Studio's test runner now: tests

I'm not sure if these are legit failures or .NET Core doesn't verify or...what. Need to investigate the last few, but the other 1,625 are ported and working great!