search

kevin1024 / vcrpy

Automatically mock your HTTP interactions to simplify and speed up testing
MIT License
2.72k stars 388 forks source link

fix: use poetry, not old setuptools #859

Closed LewisCowlesMotive closed 4 months ago

LewisCowlesMotive commented 4 months ago

This aims to solve the setuptools problem of #858 #856 and #855 but by using a more modern tool

poetry build should, AFAIK build a universal wheel for you.

https://github.com/LewisCowlesMotive/vcrpy/releases/tag/v6.0.2 has notes on testing this fix.

I don't know how your CI works, so there may yet be more adjustments there.

graingert commented 4 months ago

I think we should stick to setuptools for now. I'd merge a PR that switched to pyproject.toml based setuptools

pjonsson commented 4 months ago

@graingert is that what #767 provides, or did you have something else in mind?

Lewiscowles1986 commented 4 months ago

I'll close today. Not interested in explicit dependency on setuptools