kevinblighe / EnhancedVolcano

Publication-ready volcano plots with enhanced colouring and labeling
397 stars 81 forks source link

Issue with drawConnectors #132

Open SuhasSrinivasan opened 2 months ago

SuhasSrinivasan commented 2 months ago

Hi,

Thank you for developing and maintaining this useful package!

When following the vignette, there is an issue when using drawConnectors = TRUE

> EnhancedVolcano(res_df, lab = res_df$gene, FCcutoff = 0.5, pCutoff = 10e-1,
+                 x = 'log2FoldChange', y = 'pvalue', title = '', subtitle = '', labSize = 3,
+                 drawConnectors = T, widthConnectors = 0.5)

Error in grid.Call(C_convert, x, as.integer(whatfrom), as.integer(whatto),  : 
  Viewport has zero dimension(s)

> traceback()
23: grid.Call(C_convert, x, as.integer(whatfrom), as.integer(whatto), 
        valid.units(unitTo))
22: convertUnit(x, unitTo, "y", "dimension", "y", "dimension", valueOnly = valueOnly)
21: convertHeight(x$box.padding, "native", valueOnly = TRUE)
20: makeContent.textrepeltree(x)
19: makeContent(x)
18: drawGTree(x)
17: recordGraphics(drawGTree(x), list(x = x), getNamespace("grid"))
16: grid.draw.gTree(x$children[[i]], recording = FALSE)
15: grid.draw(x$children[[i]], recording = FALSE)
14: drawGTree(x)
13: recordGraphics(drawGTree(x), list(x = x), getNamespace("grid"))
12: grid.draw.gTree(x$children[[i]], recording = FALSE)
11: grid.draw(x$children[[i]], recording = FALSE)
10: drawGTree(x)
9: recordGraphics(drawGTree(x), list(x = x), getNamespace("grid"))
8: grid.draw.gTree(x$children[[i]], recording = FALSE)
7: grid.draw(x$children[[i]], recording = FALSE)
6: drawGTree(x)
5: recordGraphics(drawGTree(x), list(x = x), getNamespace("grid"))
4: grid.draw.gTree(gtable)
3: grid.draw(gtable)
2: print.ggplot(x)
1: (function (x, ...) 
   UseMethod("print"))(x)
R version 4.3.2 (2023-10-31)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 22.04.4 LTS
EnhancedVolcano_1.20.0  
ggplot2_3.5.0