Closed wjthieme closed 11 months ago
(recreated because I accidentally deleted my fork)
Question: do both solana-bankrun
and anchor-bankrun
need the @solana/web3.js
peer dependency or would it be sufficient if just solana-bankrun
had it?
Also I think we'll want to be stricter on version ranges
I presume by only setting it in solana-bankrun
it will be there for anchor-bankrun
as well. anchor-bankrun
does use @solana/web3.js
itself so that's why I added it. Your call!
Let me change the version ranges to only patch versions
Problem
anchor-bankrun
currently needs@coral-xyz/anchor
,@solana/web3.js
andsolana-bankrun
but they are installed as normal dependencies. This makesanchor-bankrun
use a private copy of these dependencies. This can cause issues like the following:Solution
By using peer dependencies
anchor-bankrun
expectssolana-bankrun
to be there an be within a specific version range. Added benefit is that now every time we want to updatesolana-bankrun
,anchor-bankrun
will keep working.