kevinkovalchik / RawTools

RawTools is an open-source and freely available package designed to perform scan data parsing and quantification, and quality control analysis of Thermo Orbitrap raw mass spectrometer files from data-dependent acquisition experiments.
Apache License 2.0
64 stars 19 forks source link

Installation fails: Error in htmlDependency("font-awesome", "5.3.1", "www/shared/fontawesome", : #9

Closed SamGG closed 5 years ago

SamGG commented 5 years ago

Starting from a fresh R 3.5.1 on Windows 7 x64 with Rtools35, we installed the various packages needed by RawTools

install.packages(c("shiny", "ggplot2", "reshape2", "RColorBrewer", "data.table", "shinydashboard"))

When running the shiny app, an error appears:

Error in htmlDependency("font-awesome", "5.3.1", "www/shared/fontawesome",  : 
unused argument (package = "shiny")

2018-11-28_181057

This error has been referenced at https://community.rstudio.com/t/r-shinydashboard-instructions-doesnt-work/18000/3. Installing the latest htmltools v 0.3.6 from source solves the error.

install.packages("htmltools")

For installation from source, you must install Rtools with administrative permissions and add R tools to the PATH. HTH

chrishuges commented 5 years ago

Thanks for the heads up. I just added some code to the Shiny app to check whether all required libraries are present, and if not, to install them (including htmltools). Will post the updated version here in the next day or so.

Note for RStudio users - admin is not required to run this package through RStudio.

Cheers, Chris

SamGG commented 5 years ago

Thanks. I think you should let the issue open until your really updated the repo in order to allow users to catch the solution here. Best.

chrishuges commented 5 years ago

Sorry, when I said the updated version will be posted in the next day or so, I meant in the online web interface. The source code version is posted. I should have been more specific.

SamGG commented 5 years ago

I have just checked the new code: super. Nevertheless, the library(htmltools) call is not really needed. The problem is that some package (shiny or shinydashboard) resuires a htmltools package that is 0.3.6, but this dependency is not written in the package itself. This leads to the error reported in this issue. I think there is a require() function that allows to check for a minimal version number, and if it not the case, you should add code to install the right htmltools package (from source in R/Windows). Currently in your code the htmltools package is not in the vector of packages to be installed, and the presence of the htmltools in the R installation does not guarantee that its version is correct (ie >=0.3.6). Best.

chrishuges commented 5 years ago

True, good catch! I will fix this and update the source file. It should always install the latest htmltools, so I will skip the versioning for now unless it becomes an issue for someone in the future.