search

kevinsawicki / signcode

Codesign Windows executables from a Mac
42 stars 25 forks source link

Add option for weak verification #8

Closed knuton closed 7 years ago

knuton commented 7 years ago

This adds the option to pass only an assembly path to signcode.verify and skip the leaf hash check. This is useful if the only goal is to check for the presence of a signature.

Does that make sense? I was wondering about the status of verify; it is an export but not documented or available through the CLI. I could update this PR with documentation and a CLI option if desired.

kevinsawicki commented 7 years ago

I could update this PR with documentation and a CLI option if desired.

This sounds good to me, and thanks for adding this option 👍

knuton commented 7 years ago

I just pushed a changeset which adds verify to both CLI and the docs.

As implemented, this is a breaking change, because signing via the CLI now requires use of the sign command. It could be made backwards compatible by assuming sign to be the default.

kevinsawicki commented 7 years ago

As implemented, this is a breaking change, because signing via the CLI now requires use of the sign command.

That is fine, this is still pre 1.0

kevinsawicki commented 7 years ago

Thanks for this @knuton 👍

kevinsawicki commented 7 years ago

Published as 1.0.0

knuton commented 7 years ago

Published as 1.0.0

Great, thanks! 😃