kewisch / quickmove-extension

Quick Folder Move Add-on for Thunderbird
84 stars 26 forks source link

Blank dialog on Thunderbird 128. #158

Open Wielding opened 1 month ago

Wielding commented 1 month ago

I have updated the extension for Thunderbird 128 so that it now is enabled on my installation. However, when I use the keyboard shortcut or press the "Quick Move" button when Thunderbird is maximized, most of the time I am presented with a completely empty pop-up. If I keep pressing the button eventually I get a usable pop-up, but that is rare.

When I say maximized I am refererring to it taking up an entire screen in my tiling window manager which is sway.

If I open another application next to Thunderbird so that Thunderbird is re-tilted to take up only half of my screen. The pop-up shows succesfully every time. If I close the new window to let Thunderbird once again take up the entire screen the pop-up stops working again.

It also starts working again if I make Thunderbird a floating window and shrink the width so it as a guess it might possibly related to some CSS media queries?

This was not an issue in Thunderbird 115.

127001 commented 1 month ago

Not sure if I should open a new ticket as well or follow this one. I too have an empty Quick Move dialog, every time. But unlike @Wielding, I never get contents in there.

Ubuntu 24.04 Thunderbird 128.0esr (64 Quick Folder Move 2.9.0

exmosis commented 1 month ago

I'm seeing something similar since yesterday - the list of folders is empty:

Screenshot_20240718_104704

I got it to work again by changing the Default Folders config from "Recent folders" to "All folders", then back to "Recent folders" and setting the number of recent folders to show as 10. Previously it seemed to be set to 15, and if I do set it back to 15, everything does indeed appear empty again.

Ubuntu 22.04 Thunderbird 128.0esr (64-bit) Quick Folder Move 2.9.0

127001 commented 1 month ago

Just tried that, but for me that doesn't work. And compared to you, I get nothing in the overlay.

Screenshot from 2024-07-18 12-00-25

wondering639 commented 1 month ago

had the same issue. creating a new Thunderbird profile (also implies installing the extension again there) fixed this issue for me. I am now facing https://github.com/kewisch/quickmove-extension/issues/161 though ;-)

dbonner commented 1 month ago

Creating a new Thunderbird 128 profile did not fix this problem for me. I still get a blank pop-up.

l33tllama commented 1 month ago

I'm having this issue as well with Thunderbird 128, Quick Folder Move 2.9.0 on Ubuntu 24.04. Just shows a blank box.

hkclark commented 1 month ago

I'm getting this too. When I click the Quick Move button (or use the keyboard shortcut) I get the blank popup as others have mention. In the console I get the following exception:

Uncaught (in promise) TypeError: accountMap[folder.accountId] is undefined
    fromList moz-extension://0ac9dd00-52d9-4364-97ef-3cd71a01314c/common/foldernode.js:58
    load moz-extension://0ac9dd00-52d9-4364-97ef-3cd71a01314c/popup/popup.js:101
    async* moz-extension://0ac9dd00-52d9-4364-97ef-3cd71a01314c/popup/popup.js:194
foldernode.js:58:24
    fromList moz-extension://0ac9dd00-52d9-4364-97ef-3cd71a01314c/common/foldernode.js:58
    load moz-extension://0ac9dd00-52d9-4364-97ef-3cd71a01314c/popup/popup.js:101
    InterpretGeneratorResume self-hosted:1417
    AsyncFunctionNext self-hosted:804
    (Async: async)
    <anonymous> moz-extension://0ac9dd00-52d9-4364-97ef-3cd71a01314c/popup/popup.js:194

Like @exmosis I can get it to display something if I select "All Folders" but if I then select a folder it just spins and never moves the email (which seems to be a different issue).

dochego commented 3 weeks ago

Similar to @exmosis: Switching the Default Folders config from "Recent folders" to "All folders" makes it work for me (moves emails, lets me change folders). If I switch back to "Recent folders" it fails again (with any number of folders set). "All folders" works fine.

Ubuntu 22.04 Thunderbird 128.0.1esr (64-bit) Quick Folder Move 2.9.0

kewisch commented 2 weeks ago

Fixed with Quick Folder Move 2.9.2 which is pending review.

fwinkl commented 2 weeks ago

I am still observing this issue of a blank folder list. I am on Thunderbird 128.1.0esr and Quick Folder Move 2.9.2. When clicking on the move button, I see this message in the error console:

Promise rejected after context unloaded: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved

and the popup looks like in the screenshots above. Changing from recent to all or specific folders doesn't help either.

Wielding commented 2 weeks ago

I still have the issue as well with 2.9.2 and 128.1.0 on Linux.

kewisch commented 2 weeks ago

If you look at your recent folder list, does anything pop out? Some uncommon type of folder? You can see it via right click and move/copy, this will show the built in Thunderbird recent folders.

MWWorks commented 2 weeks ago

I am having the same issue - is it maybe Linux specific? Also on Ubuntu 24.04, I have latest 2.9.2 and tried:

My behaviour is a fully blank overlay - although if I keep trying, it works randomly, maybe 1 time in 10?

My folders are a few levels deep in some places but I don't see any unusual characters or other weirdness.

dochego commented 2 weeks ago

Just to report that v2.9.2 is working fine for me on Ubuntu 22.04, TB128.1.0 installed from the tar-ball. I have got lots of nested folders, ASCII characters only for folder names.

fwinkl commented 2 weeks ago

Nothing unusual in my built-in recent folder list. Just 7 regular IMAP folders.

But I can confirm the random behavior reported by @MWWorks. For me it works about 1/20 times. The rest of the time the dialog box is empty.

l33tllama commented 2 weeks ago

With 2.9.2 I am still experiencing the issue, the pop up box is still blank I'm afraid :( Ubuntu 24.04

codexico commented 2 weeks ago

Same here, 2.9.2 and Thunderbird 128.1.0esr on Ubuntu 24.04. What I can add is that I tried the behaviors above and it opened with content just one time, after resizing the window, but never again.

Edit: I installed another addon and now the popup is always showing the content, but only on the top bar of thunderbird, still blank on the popup in the mail tab.

I suspect it's something about the space available to show the popup, already tried to change the popup to "always wide" and "always compact" but had no impact.

MWWorks commented 1 week ago

I can confirm the same behaviour as @codexico - I tried with the QuickFolders extension and also with the Signature Switch, which also adds a button to the top bar. It seems to matter that the Quick Move button is on the left, rather than the right.

Quick Move on RHS: image

Quick Move on LHS seems to consistently work: image

As per @codexico, the small button in the mail toolbar does not work: image

NB this also works without the extra extension/button IF the Quick Move button is moved to the centre or left of the top bar. I thought it was when the Quick move popup is not entirely within the bounds of the main TB window, but that doesn't align with @codexico's second screenshot.

It seems the keyboard shortcut for Go to folder, invokes the top bar button and thus works as expected; but the shortcut for Move messages invokes the smaller button and so does not work.

Hopefully this is some useful info progress :)

kewisch commented 1 week ago

This sounds very promising, hope to get back soon. Thanks for investigating!

kewisch commented 1 week ago

I wasn't able to reproduce with placement. Is there anyone not on Ubuntu/Linux where this is failing?

exmosis commented 1 week ago

Things are working much better for me with 2.9.2 - thanks for the fix. I haven't seen the issues above, but am on Linux 22 - will be interesting to see if it changes when the upgrade to 24 comes out officially soon.

I might be able to test it on Mac later on too, if time.

MWWorks commented 1 week ago

By adjusting the button position as above, this is largely resolved for me, apart from the move keyboard shortcut:

Ie if you are stuck reproducing/solving this, is it possible to change the button target of the keyboard shortcut? That would provide a workaround for all cases.

alessandromannini commented 1 week ago

Same blank popup here on Windows 11 (updated till today), TB 128 and QFM v.2.9.2

immagine

Some other hints: 1) WHEN I CLICK on the Quick Move button on the top bar I get this console error:

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgFolder.server]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource:///modules/ExtensionAccounts.sys.mjs :: convert :: line 423" data: no] ExtensionAccounts.sys.mjs:423:20 Uncaught (in promise) Error: An unexpected error occurred undefined Promise rejected after context unloaded: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved popup.js:162 unload moz-extension://078bdb44-08a9-45b6-9d6f-320e2bb76b73/popup/popup.js:162

2) WHEN I OPEN the right click menu the Move To tree is empty: immagine

Thanks Alessandro

kewisch commented 1 week ago

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgFolder.server]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource:///modules/ExtensionAccounts.sys.mjs :: convert :: line 423" data: no] ExtensionAccounts.sys.mjs:423:20

Aha, this sounds like a problem that might trigger it, but could unfortunately point to an issue in Thunderbird. It looks like the folder being shown doesn't have an incoming server associated to it, for some reason. Before you change anything in your settings please make note/screenshots of it so we can help identify the issue in Thunderbird. Can you then go through the "Server Settings" tab of each account and see if there are any invalid settings? What types of accounts do you have (email, news, etc) ?

Note to self: https://searchfox.org/comm-esr128/source/mail/components/extensions/ExtensionAccounts.sys.mjs#423

alessandromannini commented 1 week ago

Aha, this sounds like a problem that might trigger it, but could unfortunately point to an issue in Thunderbird. It looks like the folder being shown doesn't have an incoming server associated to it, for some reason. Before you change anything in your settings please make note/screenshots of it so we can help identify the issue in Thunderbird. Can you then go through the "Server Settings" tab of each account and see if there are any invalid settings? What types of accounts do you have (email, news, etc) ?

Note to self: https://searchfox.org/comm-esr128/source/mail/components/extensions/ExtensionAccounts.sys.mjs#423

Found an old (and forgotten) News account, deleted it and ALL re-started to work! Both TB standard move and QFM! With previous TB version I didn't have this problem.

Many thanks!!! Alessandro

mirenradia commented 3 days ago

I'm getting this issue with the Thunderbird flatpak (128.1.1esr) on Fedora 40 KDE.

As mentioned by a few others in this issue, I observe the behaviour where it randomly works a small proportion of the time.

I had a look at the console and I can't consistently see anything. Occasionally, I see this error message after click away from the blank dialog box.

Promise rejected after context unloaded: Actor 'Conduits' destroyed before query 'RuntimeMessage' was resolved
popup.js:162
    unload moz-extension://6cd47e63-c15f-4c7f-9228-429c8a1cd72a/popup/popup.js:162