search

key4hep / EDM4hep

Generic event data model for HEP collider experiments
https://cern.ch/edm4hep
Apache License 2.0
25 stars 36 forks source link

Load libraries without the .so suffix to make it work in other OSes #339

Closed jmcarcell closed 4 months ago

jmcarcell commented 4 months ago

Should fix https://github.com/key4hep/EDM4hep/issues/338

BEGINRELEASENOTES

ENDRELEASENOTES

tmadlener commented 4 months ago

I got a report that things work on mac OS with this.

jmcarcell commented 4 months ago

Ok I was going to test it but then I don't; it looks like this is how loading libraries is done in ROOT most of the time unless they are Linux-specific, and locally it works for me on Linux.

tmadlener commented 4 months ago

I also seem to remember documentation about this being the recommended way to do this for platform agnostic support, but I can't find that right now.

jmcarcell commented 4 months ago

There is this: https://github.com/root-project/root/blob/e42b5a6379835e541e09e577879661c538e1968f/core/unix/src/TUnixSystem.cxx#L4803 that is telling us which suffixes are being used