search

keybase / keybase-issues

A single repo for managing publicly recognized issues with the keybase client, installer, and website.
902 stars 37 forks source link

Symlinks don't work quite right #3136

Open benburrill opened 6 years ago

benburrill commented 6 years ago

Symbolic links can be viewed and followed perfectly fine on the keybase file browser. An example can be seen here, where I symlink /keybase/public/benburrill/src/style/ to /keybase/public/benburrill/style/. However, you get a 404 if you try to access /style/rst.css directly. This results in https://benburrill.keybase.pub/ not being styled appropriately because it links to /style/rst.css.

strib commented 6 years ago

cc: @malgorithms

sporkwitch commented 6 years ago

You should generally be using relative paths, I suspect that's where the issue lies here, as that does not appear to be a valid absolute path.

benburrill commented 6 years ago

It sounds like you are saying to use relative paths, but it is a relative path. I generated it in the Makefile with (effectively) ln -rs "style/" "../style" in the src directory, and readlink style shows src/style, which is the same thing the web interface shows.

Are you saying it should be an absolute path?

sporkwitch commented 6 years ago

I saw a leading / indicating an absolute. I was recommending relative links in your markup code. The other possibility is that it's dereferencing the symlinks, maybe? Apologies if I misunderstood the issue. v / r Robert Klebes Mobile: 571-492-8639 https://keybase.io/sporkwitch https://www.linkedin.com/in/klebes

On December 19, 2017 5:14:59 PM EST, Ben Burrill notifications@github.com wrote:

It sounds like you are saying to use relative paths, but it is a relative path. I generated in the Makefile with (effectively) ln -rs "style/" "../style" and readlink style shows src/style, which is the same thing the web interface shows.

Are you saying it should be an absolute path?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/keybase/keybase-issues/issues/3136#issuecomment-352902892

benburrill commented 6 years ago

You mean the <link> tag in the html? That's just referring to a url on https://benburrill.keybase.pub/, not an absolute filesystem path; the server root is /keybase/public/benburrill/.

Just to make completely sure, I replaced the symlink with a copy and it worked, so clearly it has to do with the symlink, and not the url.

zackster commented 5 years ago

There are still issues with symlinks.

For example, on macOS:

ln -s RULES.md /keybase/team/codeforcash/croupier/RULES.md

try navigating to file in Keybase GUI client file explorer - shows the file. click the preview - endless loading screen.

ok, unlink /keybase/team/codeforcash/croupier/RULES.md - file disappears, good cp RULES.md /keybase/team/codeforcash/croupier/RULES.md - shows up in Keybase file explorer, but preview screen shows "This file or folder doesn't exist" cp RULES.md /keybase/team/codeforcash/croupier/RULES2.md - shows up in file explorer and preview screen just fine

benburrill commented 5 years ago

Ok, but that seems like a separate issue related to the keybase gui. This issue is about the keybase.pub static server (where symlinks don't work), and the file browser which I reference (where symlinks do work) is the web-based keybase.pub file browser. That's different from the newer keybase gui file browser (where, as you've found, symlinks don't work).

I would report that to keybase/client, or maybe just as another issue here on keybase-issues, IDK.