search

keyboardio / Chrysalis-Firmware-Bundle

Firmware sketches for boards supported by Chrysalis
GNU General Public License v2.0
32 stars 25 forks source link

remove AlphaSquareEffect from default sketches #25

Open tlyu opened 1 year ago

tlyu commented 1 year ago

Is your feature request related to a problem? Please describe.

The AlphaSquareEffect plugin is not very legible unless translucent keycaps (or no keycaps) are installed. With the usual mostly-black opaque keycaps, it simply looks like random keys being illuminated. I had trouble figuring out what it was trying to do, until I read the description of the plugin. I still had trouble making out the letters until I happened to activate it while all my keycaps were removed (on the Model 01).

Describe the solution you'd like

Remove the AlphaSquareEffect plugin from the default sketches. This frees up some flash memory on AVR devices, and the effect doesn't look very good (and even maybe looks like an error) with the default keycaps installed.

Describe alternatives you've considered

The plugin could remain in the default sketches, taking up flash memory and looking not especially good in the default hardware configuration.

Additional context

N/A

obra commented 1 year ago

I’m fine with removing it from the default configs.

At some point, I’d love to get to “compile a bunch of effects in that are toggleable on and off by the end-user. But that’s not a prerequisite for dropping it from the default build.

On Sep 24, 2022, at 2:37 PM, Taylor Yu @.***> wrote:

 Is your feature request related to a problem? Please describe.

The AlphaSquareEffect plugin is not very legible unless translucent keycaps (or no keycaps) are installed. With the usual mostly-black opaque keycaps, it simply looks like random keys being illuminated. I had trouble figuring out what it was trying to do, until I read the description of the plugin. I still had trouble making out the letters until I happened to activate it while all my keycaps were removed (on the Model 01).

Describe the solution you'd like

Remove the AlphaSquareEffect plugin from the default sketches. This frees up some flash memory on AVR devices, and the effect doesn't look very good (and even maybe looks like an error) with the default keycaps installed.

Describe alternatives you've considered

The plugin could remain in the default sketches, taking up flash memory and looking not especially good in the default hardware configuration.

Additional context

N/A

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

algernon commented 1 year ago

There's one potential downside of removing AlphaSquare: if anyone has set up their default LED effect, to something that comes after AlphaSquare, the setting would be off by one after the removal. Colormap is listed after AlphaSquare.