search

keycdn / cache-enabler

A lightweight caching plugin for WordPress that makes your website faster by generating static HTML files.
https://wordpress.org/plugins/cache-enabler/
123 stars 46 forks source link

Fix recursive CHMOD issue #317

Closed robwoodgate closed 2 years ago

robwoodgate commented 2 years ago

Fixes #316

robwoodgate commented 2 years ago

@coreykn - this is a pretty urgent fix that prevents CE crashing websites (esp on PHP-FPM)

futtta commented 2 years ago

@svenba I've seen my site crashing as well when using keycdn on php-fpm. can't say if this was the root cause, but it seems likely?

robwoodgate commented 2 years ago

@svenba I've seen my site crashing as well when using keycdn on php-fpm. can't say if this was the root cause, but it seems likely?

Took me many days of head-scratching and site outages to figure out... and still not entirely sure how it gets triggered, but after adding lots of error logging and debug_backtraces, I narrowed it down to the chain of events I detailed in #316. The PHP-FPM crash occurs because the permissions of the socket are changed by the recursive chmod.

svenba commented 2 years ago

Thank you for the pull request! I'm going to review this in the next couple of days