search

keycloak / keycloak-quickstarts

Apache License 2.0
1.98k stars 984 forks source link

Fix connection error in service-nodejs test #386

Closed tkyjovsk closed 1 year ago

tkyjovsk commented 1 year ago

Attempt to fix connection error in service-nodejs test - #381 . Also includes recent commit from Ivan to fix app-springboot - #378 .

tkyjovsk commented 1 year ago

@vmuzikar Hm, I think you're right. The scheduled QS test workflow run against the main.

jobs:
  tests:
    name: Quickstarts tests
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        if: ${{ github.event_name != 'schedule' }}
      - uses: actions/checkout@v2
        if: ${{ github.event_name == 'schedule' }}
        with:
          ref: 'main'
tkyjovsk commented 1 year ago

Should I close this one and create new PR for main?

vmuzikar commented 1 year ago

@tkyjovsk I tried to change the base branch but there are conflicts now. Can you please fix them?

vmuzikar commented 1 year ago

BTW, definitely should go to main. 🙂 See: https://github.com/keycloak/keycloak-quickstarts/blob/06db58ad5748c874f808419582382d8b829dcdfa/CONTRIBUTING.md?plain=1#L74-L78