feat(common): work around LDML DTD bug when <import> has no base= attribute 🙀

keymanapp / keyman

Keyman cross platform input methods system running on Android, iOS, Linux, macOS, Windows and mobile and desktop web

https://keyman.com/

Other

403 stars 112 forks source link

feat(common): work around LDML DTD bug when <import> has no base= attribute 🙀 #12749

Open srl295 opened 2 days ago

srl295 commented 2 days ago

see https://github.com/keymanapp/keyman/issues/10649#issuecomment-2508421775

until https://unicode-org.atlassian.net/browse/CLDR-18138 is fixed upstream (which is on me) we could patch the LDML schema to not make base="cldr" implied. For now, authors can do <import base="" path="something.xml" />

mcdurdin commented 1 day ago

For now, authors can do <import base="" path="something.xml" />

Anything that is left for authors to workaround will live forever. Let's not go there -- we need to address this before we merge #12750, or certainly before we go to beta.

srl295 commented 1 day ago

Wasn't meaning to leave it hanging around, but wanted to split it into two problems. Sounds good as far as priority.

srl295 commented 1 day ago

Also base="" may need to be supported for compatibility with 45 and 46 DTD/Schema. Or do you think the DTD should forbid base=""?