keymanapp / lexical-models

Lexical language models for predictive text
MIT License
13 stars 38 forks source link

New Lexical Model for Burushaski YS in Perso Arabic Script #259

Closed quwatsunny closed 3 months ago

quwatsunny commented 3 months ago

Hello Team,

Kindly merge this new lexical model for the Burushaski Language.

Thanks.

keyman-server commented 3 months ago

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

DavidLRowe commented 3 months ago

Thanks for this contribution. Unfortunately there are several problems with your files.

Additional comments:

You may find it easier to close this pull request and open another with the files and folders in the correct locations, rather than correct this one. That is perfectly fine.

If anything is unclear, please ask. We understand that this process can be confusing and we appreciate your patience.

quwatsunny commented 3 months ago

Thanks for this contribution. Unfortunately there are several problems with your files.

  • You should not include the build folder or any of its files in the pull request.
  • With a base name of quwat.bsk-arab.model, your files should be in a folder with that name, which will be under a folder named quwat, which will be under the release folder (or the experimental folder if you choose). Currently you have files under release/bsk_arab/. They should be under release/quwat/quwat.bsk-arab.model. (But see the next point.)
  • Since Arabic script is the assumed script for bsk, the BCP 47 tag is expected to be bsk rather than bsk-arab (which agrees with what is in the .model_info file). That would mean the files would be under release/quwat/quwat.bsk.model. The associated keyboard should use the same bsk BCP 47 tag, so that the keyboard can connect with this model.
  • No fonts should be included with this pull request. Fonts (.ttf only; not .woff*) would be included with the keyboard (provided it is licensed with the Open Font License, or some equivalent license that allows it to be shared in that way).
  • The date in the HISTORY.md file is 2023-10-15, whereas the copyright date in the LICENSE.md file is 2024. You could change the date in the HISTORY.md file, or use "2023-2024" in the copyright statement in LICENSE.md, or somehow reconcile the two files.

Additional comments:

  • We recommend removing the date from the copyright line (or removing the copyright line entirely) in files such as readme.htm and welcome.htm, to avoid having to change these files when the model is revised.
  • We recommend removing the version number from the README.md file, to avoid having to change this file when the model is revised.

You may find it easier to close this pull request and open another with the files and folders in the correct locations, rather than correct this one. That is perfectly fine.

If anything is unclear, please ask. We understand that this process can be confusing and we appreciate your patience.

Thank you very much, I am closing this and open a new one.