search

keymanapp / lexical-models

Lexical language models for predictive text
MIT License
13 stars 38 forks source link

[sil.km.gcc] Fix custom wordbreaker output (version bump to build) #276

Closed darcywong00 closed 2 months ago

darcywong00 commented 2 months ago

This follows #265 which fixed the custom wordkbreaker output for sil.km.gcc. We held off on incrementing the version on that PR in anticipation of consolidating it with the repo-wide rebuild of #274.

@mcdurdin requested

Can we split the compiler version update into its own PR please? Then this becomes just maintenance, and issues such as the sil.lzz.laz update happening simultaneously to this won't have an impact.

So this PR will happen before #274 (which uses 17.0.329), so this build will happen with 17.0.328 stable compiler.

mcdurdin commented 2 months ago

So this PR will happen before #274 (which uses 17.0.329), so this build will happen with 17.0.328 stable compiler.

Is there any need to push two updates? Can we just use #274 to wrap up both fixes and avoid having users download two updates?

darcywong00 commented 2 months ago

Can we split the compiler version update into its own PR please?

Ah, I had read that as isolating the kmc update from the rebuild of #265.

ok - we can abandon this and let #274 handle the rebuild of #265