search

keymanapp / lexical-models

Lexical language models for predictive text
MIT License
13 stars 38 forks source link

fix[sil.cmo.bw]: follow the improved script of word prediction #281

Closed Meng-Heng closed 1 month ago

Meng-Heng commented 1 month ago

fixes: #238

keyman-server commented 1 month ago

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

DavidLRowe commented 1 month ago

One minor correction and a suggestion for clarity:

LICENSE.md This is the one file that needs to have the date (or date range). Please use "Copyright © 2021-2024 SIL Global".

HISTORY.md The description is somewhat ambiguous. "The script will handle" could be understood to mean that the script is being changed to remove punctuation marks, when the opposite is true.

Perhaps replace "This script will handle the removal..." with "This script avoids the removal..."

Meng-Heng commented 1 month ago

I have applied your suggestion, @DavidLRowe. This PR is ready for a review.