search

keymanapp / shared-sites

Shared code across keyman.com sites
MIT License
0 stars 1 forks source link

chore: v0.3: support overriding hosts, e.g. for test tier #2

Closed mcdurdin closed 1 year ago

darcywong00 commented 1 year ago

Should we note in one of the README.md files that a website may need to define SetKeymanHostsForTest() for TIER_TEST? (document for future maintannace).

I could see them permamently diverge between master and staging branches on a repo.

mcdurdin commented 1 year ago

Should we note in one of the README.md files that a website may need to define SetKeymanHostsForTest() for TIER_TEST? (document for future maintannace).

No, I think it should be okay. The presence of the override function is good self-documentation (then just search repo for it)

I could see them permamently diverge between master and staging branches on a repo.

I don't think it should diverge, hopefully. They are separate tiers so shouldn't need to diverge.