search

kfix / MacPin

a webapp container & site specific browser made from WebKit.swift and JavaScriptCore
GNU General Public License v3.0
334 stars 28 forks source link

Google Maps search broken #27

Closed empathetics closed 5 years ago

empathetics commented 7 years ago

Not sure if this is an OS compatibility issue. Thoughts? Is there support for Sierra? If there is, any other ideas what might be going on?

kfix commented 7 years ago

Details? I am running 10.12.2 with no problems on swift2.3 branch.

empathetics commented 7 years ago

See attached for the crash report - happens no matter which site I launch. MacPin Crash Report.pdf

kfix commented 7 years ago

Do you have Safari Technology Preview installed? You need that because MacPin is built against it's bundled WebKit.framework.

empathetics commented 7 years ago

It wasn't, but I just downloaded and installed it and I'm still experiencing the same issue.

On Tue, Jan 3, 2017 at 6:45 PM, Joey Korkames notifications@github.com wrote:

Do you have Safari Technology Preview installed? You need that because MacPin is built against it's bundled WebKit.framework.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kfix/MacPin/issues/27#issuecomment-270257955, or mute the thread https://github.com/notifications/unsubscribe-auth/AXwCLBDi3Sdig3tqU8Nrdgjx2wGL_ZU6ks5rOt22gaJpZM4LaI8p .

kfix commented 7 years ago

A new release probably needs to be made. That method has been switched a few times. Try updating your macOS?

empathetics commented 7 years ago

Just updated to 10.12.2, bug is still there.

On Tue, Jan 3, 2017 at 6:56 PM, Joey Korkames notifications@github.com wrote:

A new release probably needs to be made. That method has been switched a few times. Try updating your macOS?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kfix/MacPin/issues/27#issuecomment-270259642, or mute the thread https://github.com/notifications/unsubscribe-auth/AXwCLPZnLkufjx-YIscnJkf_TkEsGeUHks5rOuAUgaJpZM4LaI8p .

kfix commented 7 years ago

Did you build MacPin yourself or did you download a release?

empathetics commented 7 years ago

Downloaded a release.

On Tue, Jan 3, 2017 at 7:33 PM, Joey Korkames notifications@github.com wrote:

Did you build MacPin yourself or did you download a release?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kfix/MacPin/issues/27#issuecomment-270265490, or mute the thread https://github.com/notifications/unsubscribe-auth/AXwCLKUgbZMomxDnwGA0V3_CJQJ1y6miks5rOujjgaJpZM4LaI8p .

kfix commented 7 years ago

I see. Build swift2.3 from scratch.

empathetics commented 7 years ago

I'm sorry - new to git. What does it mean to build from scratch?

kfix commented 7 years ago

build from scratch == to compile from source code Install Xcode 8 first, then try this in Terminal.app:

git clone -b swift2.3 https://github.com/kfix/MacPin.git
cd MacPin
make reinstall
empathetics commented 7 years ago

Ok, built from scratch. All the apps were functional, with two small exceptions:

It also didn't have the following applications that had been included in the downloaded release:

kfix commented 7 years ago

try make reinstall again. sometime the icons don't build the first time and stall the build. I haven't pinned that down yet.

The Maps problem should be fixed in the swift2.3 branch, are you sure that's checked out?

Thank you for the reports, I'm sorry that the release is out-of-date and the build isn't completely smooth. There is another tranche of tweaks and features that are going out this year and will get a new release tagged for macOS Yosemite+ installs.

However GitHub is not an App Store and its issues are not a support forum. There isn't a specific bug here per-se, so I'm closing this.

kfix commented 7 years ago

my maps fixes have not been committed, will see to that

empathetics commented 7 years ago

Oh, I appreciate the help and definitely don't expect a support forum, but just wondering - wouldn't the build from scratch failing to complete be considered a specific bug? (Not a challenge - I'm genuinely new so not sure what "counts").

I did make reinstall again, and it did have the same error as the first time, described above.

kfix commented 7 years ago

Each project has their own guidelines, I didn't post mine so that's fair. That's why GitHub calls them "issues" to let it be defined by each project, or the tab can be disabled outright...

I need the build log...put it in a gist?

kfix commented 5 years ago

just tested against master, this works!