kg-construct / rml-fnml

RML-FNML: Transformation functions within RML
https://w3id.org/rml/fnml/spec
Creative Commons Attribution 4.0 International
6 stars 2 forks source link

Typo in Example 6: use nested function? #11

Closed arenas-guerrero-julian closed 1 year ago

arenas-guerrero-julian commented 1 year ago

Hi,

I have gone through the spec, it is quite clear, nice work :)

I think I found a typo, or maybe I misunderstood, in Example 6: use nested function, the current mapping for <#Execution2> is:

<#Execution2> a fnml:Execution ;               # First, replace spaces with dashes from the `name` reference
    fnml:function grel:string_replace ;
    fnml:input
        [
            a fnml:Input ;
            fnml:parameter grel:valueParam ;
            fnml:valueMap [
                rml:reference "name"
            ]
        ] ,
        [
            a fnml:Input ;
            fnml:input grel:param_find ;
            fnml:value " "
        ] ,
        [
            a fnml:Input ;
            fnml:input grel:param_replace  ;
            fnml:value "-"
        ] .

However, I was expecting:

<#Execution2> a fnml:Execution ;               # First, replace spaces with dashes from the `name` reference
    fnml:function grel:string_replace ;
    fnml:input
        [
            a fnml:Input ;
            fnml:parameter grel:valueParam ;
            fnml:valueMap [
                rml:reference "name"
            ]
        ] ,
        [
            a fnml:Input ;
            fnml:parameter grel:param_find ;
            fnml:value " "
        ] ,
        [
            a fnml:Input ;
            fnml:parameter grel:param_replace  ;
            fnml:value "-"
        ] .

That is, replacing the fnml:input with fnmlparameter.

samiscoding commented 1 year ago

Thanks @arenas-guerrero-julian, right, I fixed it!