Removing expected output from RMLTC0004b-* test-cases?

kg-construct / rml-test-cases

RML conformance test suite

http://rml.io/test-cases/

Creative Commons Attribution 4.0 International

4 stars 12 forks source link

Removing expected output from RMLTC0004b-* test-cases? #53

Open dachafra opened 3 years ago

dachafra commented 3 years ago

All of them have

Error expected: Yes
Expected knowledge graph: None, because an error is expected that stops the generation.

DylanVanAssche commented 3 years ago

I think this is a bigger problem... IMO we need proper defined errors in the spec as well that are returned.

For example:

Mapping rules invalid: return -1
Data error: return -2
...

Of course with proper semantics ;)

The idea would be that you can always expect that an engine either returns triples or exits with a defined error code.

dachafra commented 3 years ago

Could be for the future, but at this moment we have certain confusion with these test-cases as they provide the output file in Github but following the spec they shouldn't, so a way to solve it now could be removing these files.

DylanVanAssche commented 3 years ago

@dachafra agreed. It should be the same the R2RML ones are the RML ones.