kgress / scaffold

A Java based Selenium WebDriver abstraction

MIT License

4 stars 7 forks source link

Too many waitUntilDisplayed() calls when click() invoked #124

Closed kgress closed 2 years ago

kgress commented 2 years ago

Bug

An excess of waitUntilDisplayed() calls during findElements() and click() are being invoked. This is slowing overall performance.

Expected

Fundamentally, we only want one waitUntilDisplayed() called when interacting with an element.

findElements() will always wait for the parent, so I don't think we should also be waiting for children. We should change the getRawWebElement() call to instead invoke the web driver wrapper.
click() is independent of a parent and has a wait call in the scrollIntoView() script. We should change the getRawWebElement() call to instead invoke the web driver wrapper.

Repro

Invoke a findElements() call from a parent element
Observe how the parent element first is waited for, then all children are waited for

kgress commented 2 years ago

After additional investigation, the additional time is caused by click() invoking too many wait calls.