search

kha7iq / pingme

PingMe is a CLI which provides the ability to send messages or alerts to multiple messaging platforms & email.
https://pingme.lmno.pk
MIT License
771 stars 43 forks source link

Credits section in readme #39

Closed nikoksr closed 3 years ago

nikoksr commented 3 years ago

Hey @kha7iq, I remember you once contributed to notify; thanks again for that and congratulations for your great and successful project here!

I stumbled across your project through godoc and to be honest was a bit irritated that you took parts of the readme from notify (which is perfectly fine) but explicitly removed the Credits section. Like your project, notify stands on the shoulders of giants and the least we can do is give credit to those projects. Of course you can't credit every single project but if a project like yours (pingme) is based to such a large extent on a single project (notify) then we would be very grateful if you would at least credit us in your readme; especially since you yourself are part of the notify contributors.

Best regards and happy coding!

kha7iq commented 3 years ago

Hello @nikoksr Ofcource this project is based on your library and this fact is mentioned in multiple issues like https://github.com/kha7iq/pingme/issues/17 so i don't think there was any intention of hiding this fact.

The library you created is great thats why i contributed to it as well. i have no problem adding the credits to readme and honestly i did not expected the project to have this much success. :) I will update the readme and add credits. Cheers

kha7iq commented 3 years ago

Done. Readme is now updated with credits.